[PB-4258]: feat/jaas webhook #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `JitsiWebhookModule` to manage Jitsi webhook events. - Implemented `JitsiWebhookController` to handle incoming webhook requests, specifically for `PARTICIPANT_LEFT` events. - Created `JitsiWebhookService` to process participant left events and interact with room management. - Introduced interfaces for Jitsi webhook payloads to ensure type safety. - Enhanced unit tests for the webhook service and controller to validate functionality and error handling. - Updated `package.json` to include `body-parser` dependency for request handling.
… feat/jaas-webhook
xabg2
reviewed
Aug 1, 2025
|
|
||
| async createCallToken(userUuid: string) { | ||
| const meetFeatures = await this.getMeetFeatureConfigForUser(userUuid); | ||
| async createCallToken(user: User | UserTokenData['payload']) { |
Collaborator
There was a problem hiding this comment.
Just curious, what is the difference between User and UserTokenData['payload]? Is it the same? Or User is for authenticated users and UserTokenData['payload'] is for anonymous users?
| service = module.get<JitsiWebhookService>(JitsiWebhookService); | ||
|
|
||
| // Mock logger | ||
| jest.spyOn(Logger.prototype, 'log').mockImplementation(() => undefined); |
Collaborator
There was a problem hiding this comment.
Instead of mocking the logger globally, perhaps you could spy on it each time you print a log, so you can verify that the printed message is what we want.
|
|
||
| if (!roomId) { | ||
| this.logger.warn(`Could not extract room ID from FQN: ${payload.fqn}`); | ||
| return; |
Collaborator
There was a problem hiding this comment.
Maybe throwing an error explaining what happens? Or we do not want that?
|
|
||
| if (!participantId) { | ||
| this.logger.warn('Participant ID not found in payload'); | ||
| return; |
|
|
||
| if (!room) { | ||
| this.logger.warn(`Room with ID ${roomId} not found`); | ||
| return; |
[PB-4258] bugfix/Add email support to join call functionality
[PB-4936] fix: webhook signature verification
xabg2
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented jitsi's webhook to handle user disconnects. More info here