[MKT-701]:feat:Add first upload condition to FeaturesBanner display #1797
+173
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying drive-web with
|
| Latest commit: |
db21d09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60ced75e.drive-web.pages.dev |
| Branch Preview URL: | https://feature-set-new-conditions-t.drive-web.pages.dev |
CandelR
reviewed
Jan 5, 2026
Comment on lines
23
to
29
| useEffect(() => { | ||
| const timeout = setTimeout(() => setShowDelayedBanner(true), TIMEOUT); | ||
| return () => clearTimeout(timeout); | ||
| newStorageService.hasUploadedFiles().then(({ hasUploadedFiles }) => { | ||
| if (hasUploadedFiles) { | ||
| setHasUploadedFirstFile(true); | ||
| } | ||
| }); | ||
| }, []); |
Collaborator
There was a problem hiding this comment.
this logic only checks the upload status when mount hte banner, are this the behaviour that you want?
Add the related tests :)
Contributor
Author
There was a problem hiding this comment.
Yes, that's the intended behavior. I've used the same approach we have for the tutorial. I've tested it and confirmed that the banner doesn't appear after 90 seconds just from being on the homepage, and that it correctly appears 90 seconds after the first file upload. Adding the tests now.
larryrider
approved these changes
Jan 7, 2026
CandelR
approved these changes
Jan 8, 2026
|
jaaaaavier
deleted the
feature/set-new-conditions-to-show-features-banner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logic to show the FeaturesBanner only after the user has uploaded their first file and 90 seconds. This ensures new users see the banner at the appropriate time.
Related Issues
Related Pull Requests
Checklist
Testing Process
Created a new account, and uploaded File, then checked the banner displays after 90 seconds, uploaded a video on the Jira task
Additional Notes