Skip to content

Conversation

@jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented Jul 30, 2025

Description

Add a new field to the backup file json, called userUuid. This is in order to perform a check on the backend, and avoid the user potentially uploading an incorrect backup file in the rare case they have multiple Internxt accounts.
This change is backwards compatible in case #1508 goes live without this fix. Meaning that backup files that are in the new json format but dont have this new uuid field are still allowed to go through, we just simply don't perform this validation in those cases

Related Issues

https://inxt.atlassian.net/browse/PB-4737

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Saved the new backup file format. Edited the uuid purposely making it not match and verify account recovery doesnt go through. Alternatively, removed the uuid field from the backup file and checked that recovery goes through

Additional Notes

@vercel
Copy link

vercel bot commented Jul 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 6:57am

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e58cd0
Status: ✅  Deploy successful!
Preview URL: https://fd4e4548.drive-web.pages.dev
Branch Preview URL: https://fix-include-uuid-in-account.drive-web.pages.dev

View logs

@jzunigax2 jzunigax2 changed the title fix: add userUuid to BackupData structure [PB-4737]: fix/add userUuid to BackupData structure Aug 1, 2025
@jzunigax2 jzunigax2 self-assigned this Aug 1, 2025
@jzunigax2 jzunigax2 force-pushed the fix/include-uuid-in-account-recovery-v2 branch from a6e324c to cf56488 Compare August 1, 2025 06:18
@jzunigax2 jzunigax2 marked this pull request as ready for review August 1, 2025 06:18
@jzunigax2 jzunigax2 requested a review from CandelR as a code owner August 1, 2025 06:18
@CandelR CandelR requested review from a team as code owners August 11, 2025 06:48
@CandelR CandelR removed request for a team August 11, 2025 06:51
@sonarqubecloud
Copy link

@CandelR CandelR marked this pull request as draft August 12, 2025 16:07
Base automatically changed from feat/recover-private-keys to master August 13, 2025 10:39
@CandelR CandelR closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants