Skip to content

Conversation

@larryrider
Copy link
Contributor

@larryrider larryrider commented Jun 3, 2025

Description

Migrates storage endpoints from drive-old to drive-new.

  • Delete Folder: DELETE drive-old/storage/folder/{folderId} → DELETE drive/folders/{folderId}
  • Delete File: DELETE drive-old/storage/folder/${folderId}/file/${fileId} → DELETE drive/files/{fileId}
  • Storage Limit: GET drive-old/limit → GET drive/users/limit
  • Storage Usage: GET drive-old/usage → GET drive/users/usage

Related Issues

Related Pull Requests

internxt/sdk#297

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Additional Notes

@larryrider larryrider self-assigned this Jun 3, 2025
@vercel
Copy link

vercel bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2025 9:03am

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 3, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1392e5f
Status:🚫  Build failed.

View logs

@larryrider larryrider marked this pull request as ready for review June 12, 2025 15:30
@CandelR CandelR self-requested a review June 13, 2025 10:36
@TamaraFinogina
Copy link
Contributor

The test that was working before fails now: src/app/share/views/SharedGuestSignUp/ShareGuestSignUpView.test.tsx > onSubmit > when called with new valid data, then user with decrypted keys is saved in local storage

@larryrider
Copy link
Contributor Author

The test that was working before fails now: src/app/share/views/SharedGuestSignUp/ShareGuestSignUpView.test.tsx > onSubmit > when called with new valid data, then user with decrypted keys is saved in local storage

those tests are randomly failing, but they are not related to my changes. It is a known bug that its still pending to fix. They fail, but after some retries, they start working again

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let's see if we can check the problem with the tests that fail continuously, it's starting to be annoying and in the end we may miss something

@CandelR CandelR merged commit f5ac904 into master Jun 17, 2025
10 of 16 checks passed
@CandelR CandelR deleted the feat/PB-4520-migrate-storage-endpoints branch June 17, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants