Skip to content

[PB-4474]: feat/migrate-thumbnail-endpoint #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larryrider merged 3 commits into from
Jun 3, 2025
Merged

[PB-4474]: feat/migrate-thumbnail-endpoint #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
709224b
feat: migrate thumbnail generation from drive-old to drive-new
larryrider May 27, 2025
3f3c018
fix: correct method call for API security in storage client creation
larryrider May 27, 2025
84be979
Merge branch 'master' into feat/PB-4474-migrate-thumbnail-endpoint
CandelR Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/drive/components/FileViewer/FileViewerWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ const FileViewerWrapper = ({

if (isDifferentThumbnailOrNotExists && thumbnailGenerated.file) {
const thumbnailToUpload: ThumbnailToUpload = {
fileId: driveFile.id,
fileId: driveFile.uuid,
size: thumbnailGenerated.file.size,
max_width: thumbnailGenerated.max_width,
max_height: thumbnailGenerated.max_height,
Expand Down
2 changes: 1 addition & 1 deletion src/app/drive/services/file.service/uploadFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export async function uploadFile(
};
}

const generatedThumbnail = await generateThumbnailFromFile(file, response.id, userEmail, options.isTeam);
const generatedThumbnail = await generateThumbnailFromFile(file, response.uuid, userEmail, options.isTeam);
if (generatedThumbnail?.thumbnail) {
response.thumbnails.push(generatedThumbnail.thumbnail);
if (generatedThumbnail.thumbnailFile) {
Expand Down
24 changes: 12 additions & 12 deletions src/app/drive/services/thumbnail.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { getEnvironmentConfig } from './network.service';
import { FileToUpload } from './file.service/types';

export interface ThumbnailToUpload {
fileId: number;
fileId: string;
size: number;
max_width: number;
max_height: number;
Expand Down Expand Up @@ -130,19 +130,19 @@ export const uploadThumbnail = async (
abortController,
});

const storageClient = SdkFactory.getInstance().createStorageClient();
const thumbnailEntry: StorageTypes.ThumbnailEntry = {
file_id: thumbnailToUpload.fileId,
max_width: thumbnailToUpload.max_width,
max_height: thumbnailToUpload.max_height,
type: thumbnailToUpload.type,
const storageClient = SdkFactory.getNewApiInstance().createNewStorageClient();
const thumbnailEntry: StorageTypes.CreateThumbnailEntryPayload = {
bucketFile,
bucketId,
encryptVersion: StorageTypes.EncryptionVersion.Aes03,
fileUuid: thumbnailToUpload.fileId,
maxHeight: thumbnailToUpload.max_height,
maxWidth: thumbnailToUpload.max_width,
size: thumbnailToUpload.size,
bucket_id: bucketId,
bucket_file: bucketFile,
encrypt_version: StorageTypes.EncryptionVersion.Aes03,
type: thumbnailToUpload.type,
};

return await storageClient.createThumbnailEntry(thumbnailEntry);
return await storageClient.createThumbnailEntryWithUUID(thumbnailEntry);
};

/**
Expand Down Expand Up @@ -176,7 +176,7 @@ export const getThumbnailFrom = async (fileToUpload: FileToUpload): Promise<Thum

export const generateThumbnailFromFile = async (
fileToUpload: FileToUpload,
fileId: number,
fileId: string,
userEmail: string,
isTeam: boolean,
): Promise<{ thumbnail: Thumbnail; thumbnailFile: File } | null> => {
Expand Down
Loading