Skip to content

Conversation

@jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented May 15, 2025

Description

Migrate the create get usage and limit endpoints to use the new endpoints exposed in drive-server-wip

Related Issues

Related Pull Requests

#internxt/sdk/pull/289
#internxt/drive-server-wip/pull/549

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

Checking account limit and usage both on the lower section of the left sidebar and on settings under account details.

Additional Notes

@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 1:17pm

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 15, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2617ec
Status:🚫  Build failed.

View logs

@jzunigax2 jzunigax2 self-assigned this May 15, 2025
@jzunigax2 jzunigax2 marked this pull request as ready for review May 15, 2025 21:20
@jzunigax2 jzunigax2 requested a review from CandelR as a code owner May 15, 2025 21:20
@CandelR CandelR changed the base branch from master to chore/migrate-thumbnail-endpoint May 16, 2025 06:08
@sonarqubecloud
Copy link

@CandelR
Copy link
Collaborator

CandelR commented May 29, 2025

Hey @jzunigax2 , looks like it didn't pass QA. I'm moving it to Draft until I'm ready to review it again.

@CandelR CandelR marked this pull request as draft May 29, 2025 10:34
@jzunigax2
Copy link
Contributor Author

Hey @jzunigax2 , looks like it didn't pass QA. I'm moving it to Draft until I'm ready to review it again.

@CandelR sure, the issue found in qa actually occurs in the endpoint. I proposed a fixed but it hasn't been merged yet. Will let you know whenever that is done. Also since this branch stems out of the thumbnail endpoint migration that was sent to draft I'll probably need play around with git to clean this branch up

@jzunigax2
Copy link
Contributor Author

jzunigax2 commented May 30, 2025

Closing in favor of #1546, as this branch stemmed out of #1541 @CandelR

@jzunigax2 jzunigax2 closed this May 30, 2025
@larryrider larryrider deleted the chore/migrate-limt-and-usage-calls branch June 10, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants