Skip to content

Conversation

@jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented May 9, 2025

Description

Migrate the create thumbnail endpoint to use the new endpoint exposed in drive-server-wip

Related Issues

Related Pull Requests

#internxt/sdk/pull/286
#internxt/drive-server-wip/pull/543

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

Uploaded various images and pdfs in both a personal drive and business workspace and verified the thumbnails were being successfully created.

Additional Notes

@jzunigax2 jzunigax2 self-assigned this May 9, 2025
@vercel
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 3:51pm

@jzunigax2
Copy link
Contributor Author

in draft until sdk's pr is merged

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 12, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04beda6
Status:🚫  Build failed.

View logs

…ication email expectation; reorder download service imports
@jzunigax2 jzunigax2 marked this pull request as ready for review May 13, 2025 17:53
@jzunigax2 jzunigax2 requested a review from CandelR as a code owner May 13, 2025 17:53
@jzunigax2 jzunigax2 marked this pull request as draft May 13, 2025 17:53
@jzunigax2 jzunigax2 marked this pull request as ready for review May 15, 2025 03:18
@jzunigax2 jzunigax2 force-pushed the chore/migrate-thumbnail-endpoint branch from fe003fb to 04beda6 Compare May 15, 2025 15:48
@sonarqubecloud
Copy link

@CandelR
Copy link
Collaborator

CandelR commented May 29, 2025

Duplicated here #1541, if the other PR finally is released, we will close this one.
I left this one in draft.

@CandelR CandelR marked this pull request as draft May 29, 2025 10:31
@CandelR CandelR added the duplicate This issue or pull request already exists label May 29, 2025
@larryrider
Copy link
Contributor

closed in favour of #1541

@larryrider larryrider closed this Jun 3, 2025
@larryrider larryrider deleted the chore/migrate-thumbnail-endpoint branch June 10, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists enhancement New feature or request ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants