Skip to content

Conversation

@TamaraFinogina
Copy link
Contributor

@TamaraFinogina TamaraFinogina commented Jan 8, 2026

This PR removes encrypted name from updateDeviceAndFolderNameByKey function and removes unneded encryption mocks.

This function used it for 2 calls:

  • getFoldersByUserId. I changed search via name to search via plain name. The underlying function just does DB query, it's not concerned with fields names.
  • updateOneAndReturn. I removed encryptedName from attributed.

Copy link
Member

@sg-gs sg-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this affect the current situation @jzunigax2 ? I have not checked if all the devices have a plain name so the new check by plain name here will still work as expected.

@sonarqubecloud
Copy link

@jzunigax2
Copy link
Contributor

LGTM. Does this affect the current situation @jzunigax2 ? I have not checked if all the devices have a plain name so the new check by plain name here will still work as expected.

yes this should work, and actually the same exact bug happened here. Just this endpoint is not used as much as the other, so no really noticed. since we havent run the cleanup it should take care of any folder that may have gotten created on this flow

@TamaraFinogina TamaraFinogina merged commit 4937625 into master Jan 13, 2026
13 checks passed
@TamaraFinogina TamaraFinogina deleted the remove_encname_updateDeviceAndFolderNameByKey branch January 13, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants