[PB-5673] Remove encryptedName from createDeviceAsFolder #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
sg-gs
reviewed
Jan 8, 2026
| expect(folderRepository.createFolder).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('When both plain and foilder are given, then it should create a folder', async () => { |
Contributor
Author
There was a problem hiding this comment.
Oh, it should be 'plain name and bucket'. Fixed
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
|
sg-gs
approved these changes
Jan 8, 2026
Member
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
LGTM. Check if this thing affects any of your platforms guys @dajimenezriv-internxt / @AlexisMora / @patricioxavier8
jzunigax2
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
encryptedNamefromcreateDeviceAsFolder, adjustcreateFolderDeviceto not check for folder.name and adds missing tests for createFolderDeviceP.S.
createFolderDeviceis not used by any other function