[PB-5658]: fix(backups): allow device deletion on backup folder deletion #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Shouldn't we remove the device directly then? @jzunigax2 |
sg-gs
requested changes
Jan 7, 2026
| deviceId: number, | ||
| folderUuid: string, | ||
| ) { | ||
| const [_, affectedDevice] = await this.deviceModel.update( |
Member
There was a problem hiding this comment.
Avoid using business logic wording on the repository layer. It is an updated device, not an affected one
jzunigax2
force-pushed
the
fix/unable-to-backup-after-device-deletion
branch
from
ed2137c to
4197cd3
Compare
|
Contributor
Author
changed my approach a bit as I was under the impression only mac was not using the newer v2 flow so I didn't want to mix up the newer logic with the older one. But now that I know only Linux uses it I changed it so the device is deleted and created the cleanup script in another PR |
sg-gs
approved these changes
Jan 9, 2026
jzunigax2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a "device" is deleted on drive web it just deletes the folder, this caused orphaned device records pointing to a deleted root folder. Whenever the linux client attempted to recreate the device it got a conflict exception as the device already exists.
This PR allows a device to be deleted when its matching backup root folder is deleted