[PB-5580] fix(user): delete backups when resetting user account #846
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-xt
had a problem deploying
to
development
GitHub Actions
Failure
douglas-xt
changed the title
douglas-xt
force-pushed
the
fix/delete-backups-on-account-reset
branch
from
c019948 to
57300e2
Compare
douglas-xt
had a problem deploying
to
development
GitHub Actions
Failure
|
jzunigax2
reviewed
Jan 2, 2026
| deleteFolders: true, | ||
| deleteShares: true, | ||
| deleteWorkspaces: true, | ||
| deleteBackups: true, |
Contributor
There was a problem hiding this comment.
non blocking: I'm pretty sure this is now dead code, commenting just so we remember later on to double check and get rid of it
jzunigax2
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures user backups are deleted when resetting an account.
A new option was added to the account reset flow, following the same pattern as deleting files, folders, shares, and workspaces. When enabled, it removes all backup records and associated devices for the user.
Both credential update flows now delete backups when performing a reset, ensuring backups are cleaned up alongside other user data. The existing backup deletion logic was already available and used during account deactivation, so no new deletion logic was required.
The deletion removes both the backup metadata from the database and the device records associated with those backups, preventing any orphaned references.