This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[PB-3551] fix: backups are now being encrypted with bucket if needed #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apsantiso
commented
Dec 19, 2024
| : folder.name; | ||
|
|
||
| if (shouldUpdateName) { | ||
| await folder.update({ name: backupName }, { silent: true }); |
Contributor
Author
There was a problem hiding this comment.
I noticed the frontend uses updated_at to show the last modification on the backups section.
Added silent just to prevent updated_at being updated and mess with user's timestamps (however, updated_at should be updated by the backend in these cases too)
apsantiso
commented
Dec 19, 2024
Comment on lines
+23
to
+33
| function decryptNameWithNullFolderId(content) { | ||
| try { | ||
| const decryptedText = AesUtil.decrypt(content, null); | ||
|
|
||
| return decryptedText; | ||
| } catch (error) { | ||
| log.error(`(decryptNameWithNullFolderId): ${error}`); | ||
|
|
||
| return null; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Had problems with decryptName as it uses probabilistic approach if no salt provided, so I had to get directly the Aes implementation.
apsantiso
changed the title
apsantiso
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.