[_]: feature/Refactor EXIF helper functions and enhance filename generation logic #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CandelR
commented
Oct 21, 2025
CandelR
commented
- Refactored camera roll renaming functions to handle duplicates
- Added tests
- Added video prefix for videos
|
xabg2
approved these changes
Oct 23, 2025
| expect(mockGetExtensionFromUri).toHaveBeenCalledWith(uri); | ||
| }); | ||
|
|
||
| test('should use modificationTime over creationTime', () => { |
Contributor
There was a problem hiding this comment.
Just a comment. It is better to use non technical/constants names so if the variable name changes, you don't need to update the test. E.g. test('When the file is generated, then the correct date and time is used').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.