Skip to content

Fix/flaky test #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexisMora merged 3 commits into from
Nov 6, 2025
Merged

Fix/flaky test #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08b66a3
fix: flaky test using fakeTimers
AlexisMora Nov 5, 2025
a18f022
fix: restore terminal logs
AlexisMora Nov 5, 2025
02264fd
Merge branch 'main' into fix/flaky-test
AlexisMora Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/utils/logger.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,19 @@ export const webdavLogger = winston.createLogger({
}),
],
});

if (process.env.NODE_ENV !== 'production') {
webdavLogger.add(
new winston.transports.Console({
format: winston.format.simple(),
}),
);
}

if (process.env.NODE_ENV !== 'production') {
logger.add(
new winston.transports.Console({
format: winston.format.simple(),
}),
);
}
13 changes: 9 additions & 4 deletions test/webdav/services/webdav-folder.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ describe('WebDavFolderService', () => {

describe('createFolder', () => {
it('it should wait 500ms for backend propagation when folder is created', async () => {
vi.useFakeTimers();

const folderResponse = newCreateFolderResponse({
plainName: 'test-folder',
uuid: 'test-uuid',
Expand All @@ -140,20 +142,23 @@ describe('WebDavFolderService', () => {
{ cancel: () => {} },
]);

const startTime = Date.now();
const result = await sut.createFolder({
const createPromise = sut.createFolder({
folderName: 'test-folder',
parentFolderUuid: 'parent-uuid',
});
const endTime = Date.now();

await vi.advanceTimersByTimeAsync(500);

const result = await createPromise;

expect(result.uuid).to.equal('test-uuid');
expect(result.name).to.equal('test-folder');
expect(endTime - startTime).toBeGreaterThanOrEqual(500);
expect(driveFolderService.createFolder).toHaveBeenCalledWith({
plainName: 'test-folder',
parentFolderUuid: 'parent-uuid',
});

vi.useRealTimers();
});
});
});