Skip to content

Conversation

@JanickGers85
Copy link
Contributor

@JanickGers85 JanickGers85 commented Mar 4, 2025

This PR aim to solve the following WebDAV integration issue (tested with litmus)

 3. put_get............... WARNING: PUT of new resource gave 200, should be 201
    ...................... FAIL (GET of `/litmus/res' failed: 404 Not Found)
    ...................... WARNING: PUT of new resource gave 200, should be 201
    ...................... FAIL (GET of `/litmus/res-%e2%82%ac' failed: 404 Not Found)
    ...................... WARNING: MKCOL with missing intermediate gave 404, should be 409
    ...................... pass (with 1 warning)
11. mkcol_again........... WARNING: MKCOL on existing collection gave 400, should be 405 (RFC2518:8.3.2)
    ...................... pass (with 1 warning)
13. mkcol_no_parent....... WARNING: MKCOL with missing intermediate gave 404, should be 409 (RFC2518:8.3.1)
    ...................... pass (with 1 warning)
14. mkcol_with_body....... FAIL (MKCOL with weird body must fail (RFC2518:8.3.1))

This is the situation before the changes

image
And this is after the changes

image

Notes:

  • I was not able to fix the remaning two issues; I thought it was a timing issue between the PUT and the GET but even adding a timeout of 40 seconds between the two action solve the issue
  • There's one test that fail (in MKCOL.handler.test.ts), that need to be adapted to the new changes

@JanickGers85 JanickGers85 changed the title Fix/litmus test pass WebDAV server improvement for better compliance with WebDAV specifications Mar 4, 2025
@larryrider larryrider self-requested a review March 5, 2025 10:08
@JanickGers85
Copy link
Contributor Author

@larryrider Any news on this review?
I don't know how to solve the issues reported by SonarCloud.

@larryrider
Copy link
Contributor

@larryrider Any news on this review? I don't know how to solve the issues reported by SonarCloud.

I think our best option is to merge this PR into another branch, and solve it there.

Is it good for you?

@JanickGers85
Copy link
Contributor Author

@larryrider Sure, let me know to which target branch I need to change the PR.

@larryrider larryrider changed the base branch from main to feat/PB-4094-fix-litmus-tests April 7, 2025 16:26
@larryrider larryrider merged commit 8e654f4 into internxt:feat/PB-4094-fix-litmus-tests Apr 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants