-
Notifications
You must be signed in to change notification settings - Fork 102
feat(backend): add middleware that handles STREAM KYC/additional data frames #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sanducb
wants to merge
2
commits into
main
Choose a base branch
from
bs/raf-1185
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
packages/backend/src/payment-method/ilp/connector/core/middleware/kyc-decision.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { Errors } from 'ilp-packet' | ||
| import { ILPContext, ILPMiddleware } from '../rafiki' | ||
| import { StreamState } from './stream-address' | ||
|
|
||
| export function createKycDecisionMiddleware(): ILPMiddleware { | ||
| return async ( | ||
| ctx: ILPContext<StreamState>, | ||
| next: () => Promise<void> | ||
| ): Promise<void> => { | ||
| const { config, logger, redis } = ctx.services | ||
|
|
||
| // TODO This might not be needed? We should be able to just check the state.hasAdditionalData | ||
| if (!config.enableKycAseDecision) { | ||
| await next() | ||
| return | ||
| } | ||
|
|
||
| if (!ctx.state.streamDestination || !ctx.state.hasAdditionalData) { | ||
| await next() | ||
| return | ||
| } | ||
|
|
||
| const incomingPaymentId = ctx.state.streamDestination | ||
| // TODO Maybe we should have a more `unique` key? | ||
| const cacheKey = `kyc_decision:${incomingPaymentId}` | ||
|
|
||
| // Bounded polling: wait for decision up to (packet expiry - safetyMs) or maxWaitMs | ||
| const safetyMs = Number.isFinite(config.kycDecisionSafetyMarginMs) | ||
| ? config.kycDecisionSafetyMarginMs | ||
| : 100 | ||
| const maxWaitMs = Number.isFinite(config.kycDecisionMaxWaitMs) | ||
| ? config.kycDecisionMaxWaitMs | ||
| : 1500 | ||
|
|
||
| const expiresAt = ctx.request.prepare.expiresAt | ||
| const now = Date.now() | ||
| const timeRemaining = Math.max(0, expiresAt.getTime() - now - safetyMs) | ||
| const deadline = now + Math.min(timeRemaining, maxWaitMs) | ||
| const pollIntervalMs = 50 | ||
|
|
||
| const readDecision = async (): Promise<string | undefined> => { | ||
| try { | ||
| const value = await redis.get(cacheKey) | ||
| return value ?? undefined | ||
| } catch (e) { | ||
| logger.warn({ e, incomingPaymentId }, 'decision read failed') | ||
| return | ||
| } | ||
| } | ||
|
|
||
| let decision = await readDecision() | ||
| while (!decision && Date.now() < deadline) { | ||
| await new Promise((r) => setTimeout(r, pollIntervalMs)) | ||
| decision = await readDecision() | ||
| } | ||
|
|
||
| // TODO Maybe we should return reject instead? | ||
| if (!decision) { | ||
| await next() | ||
| return | ||
| } | ||
|
|
||
| if (decision === 'allow') { | ||
| await next() | ||
| return | ||
| } | ||
|
|
||
| let reason = 'rejected' | ||
| try { | ||
| const parsed = JSON.parse(decision) | ||
| reason = parsed?.reason || reason | ||
| } catch (_e) { | ||
| reason = decision | ||
| } | ||
|
|
||
| ctx.response.reject = { | ||
| code: Errors.codes.F99_APPLICATION_ERROR, | ||
| triggeredBy: ctx.services.config.ilpAddress, | ||
| message: reason, | ||
| data: Buffer.from( | ||
| JSON.stringify({ reason, incomingPaymentId }), | ||
| 'utf8' | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should throw instead and let the error handling middleware create the reject packet with a
message.