-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add Heiko kbtc #50
Conversation
…s to use extracted method
Since we will have a bunch of these prs, I would propose to setup some PR guidelines. Specifically, before merging such prs, I'd like to see some kind of proof that generated extrinsic actually works. This could be:
|
Good suggestion, thank you. For these PRs, I will not have the means to test the transactions (no funds to shuttle across the chains repeatedly). I'm not interested in gaining access to Interlay's test accounts, either. It's more secure the fewer people have access, plus there will be extensive tests once this is added to the UI. It's easy enough to provide (links to) the generated extrinsics, so providing them is a no-brainer. |
It would help but that's not a guarantee it'll work due to differences in e.g. existential deposit & fees. I think it's better to test as early as possible, rather than only after it gets added to UI. I get your point re: security, but if it's just a test account with < 100 usd worth of assets it's not much of a risk. I'd say it's worth it, especially since it also saves money in dev time if we catch problems as early as possible (no context switching, no coordinating of different people, no downstream redeployments, etc) |
…oded extrinsics in local tests via chopsticks.
…added adapter tests for parallel-heiko.
Resolves #43
Add XCM support for Heiko: KBTC
Links to constructed test tx: