Fix Django dev server port and add foo/bar favicons#82
Merged
Conversation
The Django start script bound the dev server to port 3001, but the foo and bar frontends hardcode the backend at localhost:3000 (with no proxy layer). Every sibling framework and the README already target 3000, so Django was the lone outlier — move it to 3000 so the pages work without a manual edit. Also add SVG favicons to the foo/bar static sites, which previously declared no icon link and produced 404s for /favicon.ico. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
| new Bar(); | ||
| </script> | ||
|
|
||
| <link rel="icon" type="image/svg+xml" href="favicon.svg" /> |
VishalAtIntercom
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
During Minicom setup, two rough edges surfaced:
script/django/startlaunched the Django dev server on port 3001, but the foo/bar frontends hardcode the backend athttp://localhost:3000(foo.js:3,bar.js:3) with no proxy layer. As a result the "Yay! Everything works" call failed until the port was manually edited. Every sibling framework already targets 3000 (Rails default, Nodeserver.ts=PORT || 3000) andREADME.md:54documents the webserver athttp://127.0.0.1:3000— Django was the lone outlier.foo-website/index.htmlandbar-website/index.htmldeclared no<link rel="icon">, so browsers auto-requested/favicon.icofrom the 8008/8009 static servers and got 404s.Changes
script/django/start: bind the dev server to 3000 (was 3001), matching the frontends, siblings, and the README.foo-website/favicon.svg,bar-website/favicon.svg: new inline SVG marks (text, no binary blob).foo-website/index.html,bar-website/index.html: add<link rel="icon" type="image/svg+xml" href="favicon.svg" />.No docs changes needed —
README.md:54already documents 3000, anddjango/README.mdhas no port reference.Verification
script/django/setupthenscript/django/start→ server logson port 3000and binds 3000.POST http://localhost:3000/foo→200 {"success": true}POST http://localhost:3000/bar→200 {"success": true}(the exact response the success alert checks).GET /favicon.svgreturns200 OKwithContent-Type: image/svg+xml; the icon link is present in the served HTML.Generated with Claude Code