Fix/tlp display in metadata #3160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'tlp' field to JobSerializer to include in API response - Fix plugin_name property call in elastic.py serializer - Remove debug console.log statements ( added by me ) from frontend components
mlodic
reviewed
Jan 8, 2026
Member
mlodic
left a comment
mlodic
left a comment
There was a problem hiding this comment.
there are a lot of unwanted file changes in this PR. Also there are some unwanted commits. Please re-open a clean PR.
Also, the TLP value must be shown with the correct color.
Author
|
Got it. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is my first contribution to IntelOwl. I fixed the TLP field that wasn't displaying in the job metadata toggle. The root cause was that 'tlp' was missing from the JobSerializer fields list, so it wasn't being returned in the API response.
I also fixed a related bug in elastic.py where the code was trying to call .lower() on a property object.
as this is also my first open source contribution to a actively developed open source project, i really want to know all the mistakes that i have made, so i don't repeat them again in my next contribution.
Type of change
Checklist
develop- [x] I have attached the screenshot of changes made.