-
-
Notifications
You must be signed in to change notification settings - Fork 547
Add update checker management command and documentation #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
fgibertoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lvb05 thanks for your contribution. Can you please compile the checklist in PR template ? It contains many important step to follow before asking for a review.
I’ve added and completed the PR checklist in the description. |
|
I can tell you've not read it carefully since your PR is pointing to the master branch. |
|
Hi @fgibertoni, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your PR! Looking good overall 😃
Please address the pipeline for errors.
fgibertoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks!
@mlodic for last check on expected results, otherwise we can merge this.
mlodic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please show an example output of this command? a screenshot
Also there's no cronjob here but only the management command even if we agreed on that in the issue. This won't be run by the normal user manually, we need something that runs automatically and notify the user.
Also, the cronjob would need to add a notification through the current notification system. In that way, the user would see that notification in the GUI at the top right as a message.
| All info about installation, usage, configuration and contribution can be found [here](https://intelowlproject.github.io/docs/) | ||
|
|
||
|
|
||
| ### Update Checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cannot pollute the ReadMe with this content. Please remove this line and add this instead with a new PR in the Installation section: https://github.com/intelowlproject/docs/blob/main/docs/IntelOwl/installation.md
This PR adds a basic update check mechanism for IntelOwl.
It allows to verify whether the running instance is behind the latest published GitHub release.
Included changes
api_app/core/update_checker.pyfor version fetch + comparison logiccheck_updatesUPDATE_CHECK_URL, version reuse via existing VERSION)How to use
The command will:
No version upgrade happens automatically.
Fixes #2876
Notes
UPDATE_CHECK_URLis now environment configurableVERSIONsecret settingChecklist
N/A – this PR does not introduce or modify any plugins.
N/A – this PR adds a management command and configuration logic only; existing functionality and tests are unaffected.
N/A – backend-only change.