Enhance build flags for Debug and RelWithDebInfo configurations #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianyizh
reviewed
May 16, 2025
cmake/BuildFlags.cmake
Outdated
|
|
||
| if(CMAKE_BUILD_TYPE MATCHES Debug) | ||
| set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -g) | ||
| set(SYCL_KERNEL_OPTIONS ${SYCL_KERNEL_OPTIONS} -Rno-debug-disables-optimization) |
There was a problem hiding this comment.
why we use -Rno-debug-disables-optimization on kernel option but -O0 in host option? we should keep them the same. https://github.com/intel/torch-xpu-ops/blob/main/cmake/BuildFlags.cmake#L47
chunhuanMeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the build configuration in
cmake/BuildFlags.cmakefor different build types. The changes focus on improving debugging capabilities and adding specific flags forDebugandRelWithDebInfobuild types.Debugging and Optimization Flags:
CMakeLists.txtto automatically enableBUILD_SEPARATE_OPSwhen the build type isDebugorRelWithDebInfo.SYCL_HOST_FLAGSfor theDebugbuild type to include-g,-fno-omit-frame-pointer, and-O0, and added a new configuration for theRelWithDebInfobuild type with-gand-O2.SYCL_KERNEL_OPTIONSto add-g -O0 -Rno-debug-disables-optimizationforDebugbuilds and-gline-tables-only -O2forRelWithDebInfobuilds.