Rename USE_ONEMKL as USE_ONEMKL_XPU and set it as default ON #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuiYifeng
force-pushed
the
yifeng/rename_mkl_env
branch
from
761ba29 to
88de14e
Compare
CuiYifeng
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR renames the preprocessor macro from USE_ONEMKL to USE_ONEMKL_XPU for clearer differentiation between oneMKL XPU and oneMKL CPU, and sets the new macro as the default ON option.
- Update macro conditionals in xpu/mkl-specific source files
- Update build workflow configuration to reflect the renaming
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/mkl/SpectralOps.cpp | Updated macro conditionals to use USE_ONEMKL_XPU |
| src/ATen/native/xpu/SpectralOps.cpp | Updated macro conditionals in xpu FFT functions to use USE_ONEMKL_XPU |
| .github/workflows/_windows_ut.yml | Updated workflow configuration to set USE_ONEMKL_XPU to 1 |
Files not reviewed (4)
- .github/scripts/build.sh: Language not supported
- cmake/ONEMKL.cmake: Language not supported
- src/BuildOnLinux.cmake: Language not supported
- src/BuildOnWindows.cmake: Language not supported
|
@chuanqi129 @fengyuan14 Please help review, thanks. |
chuanqi129
reviewed
May 19, 2025
.github/scripts/build.sh
Outdated
| @@ -50,7 +50,7 @@ git submodule sync && git submodule update --init --recursive | |||
| python -m pip install -r requirements.txt | |||
| python -m pip install mkl-static mkl-include | |||
| export USE_STATIC_MKL=1 | |||
| export USE_ONEMKL=1 | |||
| export USE_ONEMKL_XPU=1 | |||
There was a problem hiding this comment.
Is there any simple API can check whether the oneMKL is compiled and enabled? If have we can add it in the verify part of this script
There was a problem hiding this comment.
These is no such API available. Checking if libtorch_xpu.so => libmkl_sycl_*.so is an alternative method.
fengyuan14
reviewed
May 20, 2025
CuiYifeng
force-pushed
the
yifeng/rename_mkl_env
branch
from
88de14e to
78f38e6
Compare
4 tasks
chuanqi129
approved these changes
May 22, 2025
fengyuan14
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.