[Benchmarks] Benchmarks scripts cleanup #20460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
approved these changes
Oct 24, 2025
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@lslusarczyk, @lukaszstolarczuk, Is the |
PatKamin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
PatKamin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Improve readability: - group methods and attributes into public, protected (underscore prefix) and private (double underscore prefix) - order public methods to align with their order in the base Benchmark class
|
|
||
| def description(self) -> str: | ||
| return "" | ||
|
|
There was a problem hiding this comment.
in general I like this cleanup, but I guess we may quickly forget about this "new order" - perhaps add "sections", e.g. put a comment here. Just an idea - please do as you think.
#
## Protected functions
#
|
|
||
| def description(self) -> str: | ||
| return "" | ||
|
|
There was a problem hiding this comment.
perhaps also, describe this shortly in our contrib guide...?
| ## Adding New Benchmarks | ||
|
|
||
| 1. **Create Benchmark Class:** Implement a new class inheriting from `benches.base.Benchmark`. Implement required methods (`setup`, `run`, `teardown`, `name`) and optional ones (`description`, `get_tags`, etc.) as needed. | ||
| 1. **Create Benchmark Class:** Implement a new class inheriting from `benches.base.Benchmark`. Implement required methods (`run`, `name`) and optional ones (`description`, `get_tags`, etc.) as needed. |
There was a problem hiding this comment.
setup() is mentioned above as required method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.