feat: OutputEngine updates for no-scan #5195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
=========================== short test summary info ============================
FAILED test/test_output_engine.py::TestOutputEngine::test_output_with_unset_fields - AssertionError: OutputEngine.output_cves raised an exception when 'sbom_serial_number' was unset: cannot unpack non-iterable NoneType object
FAILED test/test_source_purl2cpe.py::TestSourceOSV::test_db_contents[1-False] - AssertionError: Missing elements in database: ['pkg:1234n/minicms', 'pkg:13thmonkey/udfclient', 'pkg:23systems/lightbox-plus-for-wordpress', 'pkg:2glux/sexypolling', 'pkg:2pisoftware/cmfive']
assert not ['pkg:1234n/minicms', 'pkg:13thmonkey/udfclient', 'pkg:23systems/lightbox-plus-for-wordpress', 'pkg:2glux/sexypolling', 'pkg:2pisoftware/cmfive']
=========== 2 failed, 297 passed, 2035 skipped in 167.64s (0:02:47) ============Both of these failing tests are unrelated to my changes. The OSV one is pretty expected since @terriko mentioned that there might be some missing data. The other one one seems to be a problem with lib4vex, so tagging @anthonyharrison here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutputEngine Updates for No-Scan Work.
Currently the console throws a bunch of vendor, product, version and last stable version information as a table output