Fix: add missing ret=-1 on tee_verify_quote failure (untrusted path) in QuoteVerificationSample #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sample untrusted quote verification path of
ecdsa_quote_verification(),when
tee_verify_quote()fails, the function jumps to cleanup without settingret = -1. This may result in returning 0 (success) even though theverification failed.
This patch aligns the untrusted path with the trusted path, which correctly
sets
ret = -1on failure, ensuring consistent and safe error handling.No functional impact on successful flows.
Verified build on Ubuntu 24.04 with SGX SDK 2.26 and DCAP 1.23.