Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruleset option do_not_enforce_on_create #2361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MattMencel
Copy link

@MattMencel MattMencel commented Aug 22, 2024

Optional attribute added to rules.required_status_checks.

Depends on google/go-github#3245. It was just released in v65.0.0.

Resolves #2360


Before the change?

  • The option to allow repositories and branches to be created if a check would otherwise prohibit it, was not available.

After the change?

  • The option to allow repositories and branches to be created if a check would otherwise prohibit it, is available through the provider.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

@MattMencel MattMencel marked this pull request as ready for review September 16, 2024 18:38
@MattMencel MattMencel force-pushed the ruleset_do_not_enforce_on_create branch from 2404cf7 to 9b25581 Compare September 16, 2024 18:38
@MattMencel MattMencel force-pushed the ruleset_do_not_enforce_on_create branch from 9b25581 to 5cef316 Compare October 11, 2024 21:37
@stevehipwell
Copy link
Contributor

@kfcampbell could this get a review?

@MattMencel MattMencel force-pushed the ruleset_do_not_enforce_on_create branch from 5cef316 to 2d83c7b Compare November 21, 2024 16:08
@MattMencel
Copy link
Author

Can someone please add this to the next release, and soonish? It's been pending for several months and is a big pain point for us.

Without this, Rulesets on non-trunk branches break regularly for us. I think every time we apply Terraform, the "Do not require status checks on creation" box gets unchecked, even though it's not currently manageable from Terraform. Then, the normal workflow pattern for our devs breaks, and we have to fix it manually.

🥺 🙏

Screenshot 2024-11-22 at 9 41 20 AM

@lfventura
Copy link

This is also being a huge problem for us. It looks this PR address it for a long time but still not merged... Any news regarding it @kfcampbell ?

@lfventura
Copy link

@MattMencel I had problems building your PR, which was causing an error.

I made a new PR which I could prove the funcionality and it is working good.
As you have the same need as I do, I am putting here my PR(#2525) and while Github does not publish this officially, I have also published my version of the provider with this change... I will try to keep it updated with the origin repo until we have if official in the github provider. If you want to use it too it is this provider https://registry.terraform.io/providers/lfventura/github/latest, currently .

@kfcampbell Please advise :)

Optional attribute added to rules.required_status_checks.
@MattMencel MattMencel force-pushed the ruleset_do_not_enforce_on_create branch from 2d83c7b to dc63a75 Compare December 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Rulesets - Do not require status checks on creation
3 participants