Added support for Stripe 14 and 15#172
Merged
rmm5t merged 1 commit intointegrallis:masterfrom Apr 21, 2025
Merged
Conversation
nplusp
changed the title
Contributor
Author
|
It looks like some specs for Rails 6.0 are not passing for me. I'm checking to see if this might be the problem in the code and if there's a way to fix it. |
Member
|
Thank you. I think the underlying problem is due to an incompatibility with concurrent-ruby 1.3.5 and rails <= 7.0. I'm preparing another pull request to fix the CI suite. Please stand by. Working on that here: #173 |
Member
|
I fixed the older portions of the build matrix in #173 In theory, if this PR was rebased it would go green now, so I'm just going to merge and monitor the master branch. |
Member
Contributor
Author
|
That’s neat @rmm5t — thanks for quick response! |
Member
|
@nplusp Thanks for the contribution. Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Stripe 14 and Stripe 15