-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine existing checks #55
Conversation
e13555d
to
2d863a2
Compare
b0c16b5
to
b16b7d0
Compare
c112238
to
44aa72a
Compare
649a831
to
43754cf
Compare
to flag each point based on ALL the windows that include it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor formatting stuff I noticed. Also, it might be useful to implement Ord
for Flags
(in the future), it could simplify the flag coalescing part of the code?
It's tempting, but are we sure the precedence order for coalescing will always be the same? |
No, that's why I said in the future :) However, having checks implementing different flag precedence doesn't sound right? |
I could imagine a check that looks for a success condition instead of a fail condition having a different order, idk if that will happen in practice though |
DataCache
for consistency checks