Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine existing checks #55

Merged
merged 22 commits into from
Nov 27, 2024
Merged

Refine existing checks #55

merged 22 commits into from
Nov 27, 2024

Conversation

intarga
Copy link
Owner

@intarga intarga commented Nov 13, 2024

  • fix monotonic_increase_check based on Øystein's feedback
  • implement monotonic_increase_check_cache
  • better structure for min_less_than_single etc. 3 checks instead of 4
  • individual flags for the above consistency checks
  • come up with an equivalent to DataCache for consistency checks
  • make cache versions of existing consistency checks

@intarga intarga added the enhancement New feature or request label Nov 13, 2024
@intarga intarga marked this pull request as draft November 13, 2024 15:18
src/util/mod.rs Show resolved Hide resolved
src/checks/consistency/single_greater_than_any.rs Outdated Show resolved Hide resolved
src/checks/consistency/single_greater_than_any.rs Outdated Show resolved Hide resolved
src/checks/consistency/single_less_than_any.rs Outdated Show resolved Hide resolved
src/checks/consistency/single_outside_sequence.rs Outdated Show resolved Hide resolved
src/checks/series/monotonic_decrease_check.rs Outdated Show resolved Hide resolved
src/checks/series/monotonic_decrease_check.rs Show resolved Hide resolved
src/checks/series/monotonic_decrease_check.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Lun4m Lun4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor formatting stuff I noticed. Also, it might be useful to implement Ord for Flags (in the future), it could simplify the flag coalescing part of the code?

src/checks/consistency/single_outside_sequence.rs Outdated Show resolved Hide resolved
src/checks/consistency/single_outside_sequence.rs Outdated Show resolved Hide resolved
@intarga
Copy link
Owner Author

intarga commented Nov 26, 2024

Also, it might be useful to implement Ord for Flags

It's tempting, but are we sure the precedence order for coalescing will always be the same?

@intarga intarga requested a review from Lun4m November 26, 2024 18:10
@Lun4m Lun4m merged commit 18e5697 into trunk Nov 27, 2024
1 check passed
@Lun4m Lun4m deleted the check_refinement branch November 27, 2024 07:36
@Lun4m
Copy link
Collaborator

Lun4m commented Nov 27, 2024

No, that's why I said in the future :) However, having checks implementing different flag precedence doesn't sound right?

@intarga
Copy link
Owner Author

intarga commented Nov 27, 2024

No, that's why I said in the future :) However, having checks implementing different flag precedence doesn't sound right?

I could imagine a check that looks for a success condition instead of a fail condition having a different order, idk if that will happen in practice though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants