Columns with iterables given directly in the catalog spec#752
Open
aulemahal wants to merge 4 commits intointake:mainfrom
Open
Columns with iterables given directly in the catalog spec#752aulemahal wants to merge 4 commits intointake:mainfrom
aulemahal wants to merge 4 commits intointake:mainfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds a "iterable_columns" field in the ESM Catalog Spec that acts the same as the
columns_with_iterablesargument of theesm_datastore.The ESMCatalogModel object has a
columns_with_iterablesproperty that returns the actual list of columns containing iterables, which could be a superset ofiterable_columnsifconverterswere given in theread_kwargs. Thus, I had to choose a different name for the config-provided version.Related issue number
Fixes #595
Checklist
I gathered that deprecating
columns_with_iterableswould be much too breaking. This means the same thing can be done in two ways. Is this ok?I only added a small test. The test suite already makes a good job testing the "iterable" feature, I only tested the catalog opening when the new option is given.