Conversation
Add note on default's that might have changed?
|
@charles-turner-1 - let me know when you would like a review here |
|
Sorry Max, completely forgot to reply to you here! We've been using a fork the past month or so to allow us to go further/faster with development on this - I think there are a couple of minor tweaks there that need merging back into here. I'll ping you for a review once I'm satisfied that everything is working as intended! (N.B I'm mostly treating our fork as something of a staging area - intention is to sync developments back in here.) |
|
No worries @charles-turner-1 👍 sounds like a plan!! |
|
(We implemented this & the concomitant change to ecgtools on our forks ~ 6 weeks ago with no hitches. I've been slammed with other stuff but I'll check push those changes back to here & ecgtools either this week or early next week). |
Change Summary
.parquetfiles, but completely forgot to add support for serialising catalogs back to them. This PR fixes that.write_kwargs, a laread_kwargsin Add parquet driver #728, plus soft deprecation of theto_csv_kwargskeywods argument when serialising.N.B: Deserialisation & reserialisation tests round trip twice, it looks like the defaults for how empty catalog field options (in
catalog.json) have changed since that catalog was created.Checklist
ecgtoolsfirst to allow for quickstart guide update.I will no longer make pull requests when jetlagged.