Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade libwebrtc 132.0.6834.83 #184

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Upgrade libwebrtc 132.0.6834.83 #184

wants to merge 8 commits into from
+18 −19

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Jan 21, 2025 •
edited
Loading

Synopsis

libwebrtc 132.0.6834.83 was released, so we need to update it in flutter-webrtc.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file labels Jan 21, 2025
@evdokimovs evdokimovs self-assigned this Jan 21, 2025
@evdokimovs
Copy link
Author

FCM

Upgrade libwebrtc 132.0.6834.83 (#184)

evdokimovs
evdokimovs commented Jan 22, 2025
View reviewed changes
example/integration_test/webrtc_test.dart Outdated
@@ -299,16 +299,13 @@ void main() {
'audio/opus',
'audio/red',
'audio/G722',
// 'audio/ILBC',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audio/ILBC was removed from the recent version of libwebrtc due to its declining usage:

https://issuetracker.google.com/issues/372395680

@evdokimovs evdokimovs marked this pull request as ready for review January 22, 2025 16:10
@evdokimovs evdokimovs requested a review from tyranron January 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron Awaiting requested review from tyranron

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evdokimovs