-
Notifications
You must be signed in to change notification settings - Fork 107
chore(many): make documentation preview builds show console messages #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(many): make documentation preview builds show console messages #2148
Conversation
|
a3b7be0 to
0144089
Compare
6e32547 to
1b610ed
Compare
c92a563 to
01766ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments
| new webpack.DefinePlugin({ | ||
| 'process.env.GITHUB_PULL_REQUEST_PREVIEW': JSON.stringify(GITHUB_PULL_REQUEST_PREVIEW), | ||
| }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matyasf I tried to omit this plugin, but it results in process.env.GITHUB_PULL_REQUEST_PREVIEW becoming undefined in the browser. This makes environment variable values available in client-side.
2fcd1ad to
1a8b263
Compare
1a8b263 to
9d7ac91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, this will help a lot with quick debugging
INSTUI-4522
ISSUE:
TEST PLAN: