Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: passwordless auth #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: passwordless auth #63

wants to merge 2 commits into from

Conversation

bamorim
Copy link
Contributor

@bamorim bamorim commented Feb 22, 2021

Reimplementação do #8 usando versões mais novas das libs.

@bamorim bamorim force-pushed the passwordless-auth branch from 64bd152 to 994d20f Compare March 14, 2021 23:33
@bamorim bamorim marked this pull request as ready for review March 14, 2021 23:33
@bamorim
Copy link
Contributor Author

bamorim commented Mar 14, 2021

Coloquei a página demonstrando as formas de usar o Next Auth no /demoauth e escondi tudo atras da feature flag dashboardEnabled.

return nodemailer.createTransport({
...getServiceOptions(service),
auth,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do jeito que fazemos hoje, estamos mandando email tanto pelo mailhog quanto pelo serviço original (e.g. gmail) caso as env keys do gmail estejam listadas em .env .
Acho melhor ser exclusivo - ou gmail ou mailhog

}
}

throw new Error("User without email");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse erro estoura para o usuario? Se sim, coloca uma mensagem em portugues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants