refactor: remove redundant make_*_buffer functions and rename create_*_buffer to make_*_buffer functions#63
Merged
SimonDuToit merged 1 commit intoinstadeepai:mainfrom Aug 5, 2025
Conversation
- Remove make_flat_buffer in favor of create_flat_buffer - Remove make_item_buffer in favor of create_item_buffer - Resolves redundancy issue where make_* functions simply called create_* functions Fixes issue instadeepai#56
SimonDuToit
approved these changes
Aug 5, 2025
Collaborator
SimonDuToit
left a comment
SimonDuToit
left a comment
There was a problem hiding this comment.
Awesome, thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #56