-
Notifications
You must be signed in to change notification settings - Fork 14
Replace earthly #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gilligan
wants to merge
16
commits into
master
Choose a base branch
from
replace-earthly
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace earthly #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@skylar-simoncelli All pre-merge steps seem to work. I haven't tested post-merge so I'm gonna assume that's where all my typos are and everything breaks :) |
Some issues spotted on a quick review:
In current state it looks like pre-merge is correct, and post-merge and workflow_dispatch are 90% there with just these minor issues |
LGLO
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces earthly by instead relying on a more simplistic setup where the build time dependencies are provided via Nix from our flake.nix
Some additional notes:
flake.nix
has been reduced a lot in size recently and is now just 114 linesChecklist
changelog.md
for affected crate