Skip to content

fix: sort candidates inside ariadne_v2, to make it tolerant for unsorted inputs #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented May 27, 2025

Description

Node is not sorting registered candidates and it never was doing it.
Ariadne v1 was sorting them. Ariadne v2 was not. This fixes this missing sorting in Ariadne v2.

ETCM-11891

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO LGLO force-pushed the etcm-11891-fix-aridande-v2-not-sorting-candidates branch from 1c82fe3 to 12970f7 Compare May 27, 2025 09:53
@LGLO LGLO merged commit a14e17e into master May 28, 2025
37 checks passed
@LGLO LGLO deleted the etcm-11891-fix-aridande-v2-not-sorting-candidates branch May 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants