Skip to content

add docs for cli commands #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

add docs for cli commands #811

wants to merge 4 commits into from

Conversation

gilligan
Copy link
Contributor

Description

Adds documentation of all pc cli commands

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@gilligan gilligan marked this pull request as draft May 21, 2025 15:12
@gilligan
Copy link
Contributor Author

Still needs some more work..

```

##### upsert-d-parameter
Upsert D-parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it isn't enough to enumerate governance related smart contracts without additional documentation here. IMO these comments don't add value.

Copy link
Contributor Author

@gilligan gilligan May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% right and agreed. That's the very reason why the PR is still in DRAFT. Whenever the documentation only repeats the name of the command that really doesn't help a lot

I started off with copying what the user is provided in the --help which as you can see in most cases really isn't a lot

gilligan and others added 2 commits May 22, 2025 16:04
Co-authored-by: Lech Głowiak <[email protected]>
Co-authored-by: Lech Głowiak <[email protected]>
--genesis-utxo <GENESIS_UTXO>
```
###### update
Updates a key-value pair in the Governed Map. If the key is missing it won't be inserted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also

	/// If provided, update will fail unless the current value matches the one on the ledger.
	current_value: Option<ByteString>,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants