Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: local-env with wizard-spawned network #443

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

rsporny
Copy link
Collaborator

@rsporny rsporny commented Feb 3, 2025

Description

feat: local-env with wizard-spawned network

Refs: ETCM-9298

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not ruin local-environment but I would much prefer code for testing wizards in E2E tests.

Copy link
Contributor

@skylar-simoncelli skylar-simoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! The entrypoint scripts are great, nice use of expect. And it looks like the deployment option has been integrated properly, don't see anything missing

@skylar-simoncelli
Copy link
Contributor

Do we want to run a second parallel local-environment in CI using deployment option 5?

@rsporny
Copy link
Collaborator Author

rsporny commented Feb 3, 2025

@skylar-simoncelli yes, I'll integrate it in CI once I'll fix starting one node with rpc/ws connection allowed. start-node doesn't allow external connections, so we can't use our tests yet.

Copy link
Contributor

@kpinter-iohk kpinter-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rsporny rsporny enabled auto-merge (squash) February 3, 2025 11:56
@rsporny rsporny merged commit 495d47a into master Feb 3, 2025
11 checks passed
@rsporny rsporny deleted the wizard-automation branch February 3, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants