Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: ETCM-8739 include input data hash in committee selection inherent #436

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Jan 30, 2025

Description

  • Includes a Blake2 hash of the inherent data used in the pallet-session-validator-management's set inherent.
  • Includes hash information in the error if the committee doesn't match expected
  • Logs a warning if correct committee is selected but a hash mismatch is detected

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea marked this pull request as ready for review January 30, 2025 14:59
@AmbientTea AmbientTea requested a review from LGLO January 30, 2025 14:59
@AmbientTea
Copy link
Contributor Author

Tested this version by upgrading an already running chain on devnet. The blocks are correctly produced and imported.

@AmbientTea AmbientTea force-pushed the ETCM-8739-data-hash-in-committee-selection branch from e2fdb81 to 5cb1a2c Compare February 3, 2025 14:06
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
@AmbientTea AmbientTea force-pushed the ETCM-8739-data-hash-in-committee-selection branch from 83ae81d to 9daf040 Compare February 3, 2025 21:41
@AmbientTea AmbientTea requested a review from LGLO February 3, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants