Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etcm 9058 remove pc contracts cli from tests #434

Merged
merged 13 commits into from
Jan 30, 2025

Conversation

rsporny
Copy link
Collaborator

@rsporny rsporny commented Jan 30, 2025

Description

test: use node binary instead of PCSC

  • removed pc-contracts-cli container
  • removed pc-contracts-cli and partner-chains-cli artifacts
  • removed --overrides artifacts option

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

Copy link
Contributor

@skylar-simoncelli skylar-simoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flake.nix Outdated Show resolved Hide resolved
@rsporny rsporny merged commit c97d2ba into master Jan 30, 2025
11 checks passed
@rsporny rsporny deleted the ETCM-9058-remove-pc-contracts-cli-from-tests branch January 30, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants