Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-refactor: do not overspecify read operations order or number #428

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Jan 28, 2025

Description

Step 1 of files operations overspecification clean-up. It is simple, because this is about reads only. We should not care about when something is read or how many times. Mock files are setup in tests and updated by write operations. Nothing else matters.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@LGLO LGLO requested review from jankun4, kpinter-iohk and AmbientTea and removed request for jankun4 and kpinter-iohk January 28, 2025 11:39
@LGLO LGLO force-pushed the ETCM-9274-do-not-overspecify-file-read-operations branch from d30ac35 to 27bb0ad Compare January 28, 2025 14:11
@LGLO LGLO force-pushed the ETCM-9274-do-not-overspecify-file-read-operations branch from 27bb0ad to ff324d8 Compare January 28, 2025 20:49
@LGLO LGLO enabled auto-merge (squash) January 28, 2025 20:49
@LGLO LGLO merged commit 15112e2 into master Jan 28, 2025
11 checks passed
@LGLO LGLO deleted the ETCM-9274-do-not-overspecify-file-read-operations branch January 28, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants