test: fix return type

input-output-hk · Jan 30, 2025 · cc5bcc2 · cc5bcc2
1 parent 2ebba93
commit cc5bcc2
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 11 deletions.
diff --git a/E2E-tests/src/partner_chains_node.py b/E2E-tests/src/partner_chains_node.py
@@ -93,7 +93,7 @@ def update_d_param(self, permissioned_candidates_count, registered_candidates_co
             return tx_id
         else:
             logger.error(f"Wrong response format of upsert-d-parameter command: {response}")
-            return None, None
+            return None
 
     def register_candidate(self, signatures: RegistrationSignatures, payment_key, spo_public_key, registration_utxo):
         register_cmd = (
@@ -116,7 +116,7 @@ def register_candidate(self, signatures: RegistrationSignatures, payment_key, sp
             return tx_id
         else:
             logger.error(f"Wrong response format of register command: {response}")
-            return None, None
+            return None
 
     def deregister_candidate(self, payment_key, spo_public_key):
         deregister_cmd = (
@@ -135,7 +135,7 @@ def deregister_candidate(self, payment_key, spo_public_key):
             return tx_id
         else:
             logger.error(f"Wrong response format from deregister command: {response}")
-            return None, None
+            return None
 
     def upsert_permissioned_candidates(self, governance_key, new_candidates_list):
         # Create permissioned candidates file to be used in CLI command
@@ -167,7 +167,7 @@ def upsert_permissioned_candidates(self, governance_key, new_candidates_list):
             return tx_id
         else:
             logger.error(f"Wrong response format from upsert-permissioned-candidates command: {response}")
-            return False, None
+            return None
 
     def handle_response(self, result):
         if result.stderr and not result.stdout:

diff --git a/E2E-tests/src/substrate_api.py b/E2E-tests/src/substrate_api.py
@@ -719,5 +719,5 @@ def __get_data_from_db_sync(self, query, retries=5, delay=10):
         raise Exception(f"Query: {query} failed after {retries} retries")
 
     def _effective_in_mc_epoch(self):
-        """Calculates main chain epoch in which smart contracts operation will be effective."""
+        """Calculates main chain epoch in which smart contracts candidates related operation will be effective."""
         return self.cardano_cli.get_epoch() + 2
diff --git a/dev/local-environment/README.md b/dev/local-environment/README.md
@@ -19,7 +19,7 @@ The stack `setup.sh` script will create a docker-compose.yml stack configuration
 
 - When first run, all images will be pulled from public repositories. This stage may take some time. The stack will then be built and run.
 - When the stack is running, the Cardano node begins block production. This is a private testnet and will not connect to the public Cardano network, but rather from a pre-configured genesis file.
-- Once the Cardano chain is synced, Ogmios, and DB-Sync will in turn connect to the Cardano node node.socket and begin syncing the chain.
+- Once the Cardano chain is synced, Ogmios and DB-Sync will in turn connect to the Cardano node node.socket and begin syncing the chain.
 - The partner-chains-setup will insert D parameter values and register Partner Chains Node keys with the Cardano chain.
 - Once Postgres is populated with the required data, the Partner Chains nodes will begin syncing the chain and will begin block production after 2 main chain epochs.
 

diff --git a/dev/local-environment/setup.sh b/dev/local-environment/setup.sh
@@ -251,7 +251,6 @@ CPU_DBSYNC=0.000
 MEM_DBSYNC=1000G
 CPU_OGMIOS=0.000
 MEM_OGMIOS=1000G
-ARTIFACT_OVERRIDE=$overrides
 EOF
     else
         cat <<EOF >.env
@@ -268,7 +267,6 @@ CPU_DBSYNC=$cpu_dbsync
 MEM_DBSYNC=$mem_dbsync
 CPU_OGMIOS=$cpu_ogmios
 MEM_OGMIOS=$mem_ogmios
-ARTIFACT_OVERRIDE=$overrides
 EOF
     fi
 

diff --git a/docs/user-guides/chain-builder.md b/docs/user-guides/chain-builder.md
@@ -21,7 +21,7 @@ Partner Chain builders are organizations that want to build their own blockchain
 
 To run the Partner Chains stack, several dependencies need to be installed on a `cardano-node`.
 
-Ogmios, and DB Sync are essential to enable registration communication with the main chain (Cardano). Ogmios is used for submitting transactions to Cardano, and DB Sync is for observation of main chain state.
+Ogmios and DB Sync are essential to enable registration communication with the main chain (Cardano). Ogmios is used for submitting transactions to Cardano, and DB Sync is for observation of main chain state.
 
 ### 1.1 Cardano node v10.1.4
 
@@ -187,7 +187,7 @@ journalctl -fu cardano-db-sync.service
 ---
 **WARNING**
 
-Ensure that the node is synced with the network to 100% as well and DB Sync before continuing beyond this point. On preview network, it is roughly 24 hours before sync is complete.
+Ensure that the node is synced with the network to 100% as well as DB Sync before continuing beyond this point. On preview network, it is roughly 24 hours before sync is complete.
 
 ---
 

diff --git a/docs/user-guides/registered.md b/docs/user-guides/registered.md
@@ -32,7 +32,7 @@ Once you have the Cardano SPO keys, you are ready to continue with this guide.
 
 To run the partner chains stack, several dependencies need to be installed on the Cardano node.
 
-Ogmios, and DB Sync are essential to enable registration communication with the main chain (Cardano).
+Ogmios and DB Sync are essential to enable registration communication with the main chain (Cardano).
 
 ### 2.1 Cardano node dependencies