Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End support for MacOS x64 pre-built binaries #2277

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

End support for MacOS x64 pre-built binaries #2277

wants to merge 3 commits into from
+19 −32

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 5, 2025 •
edited
Loading

Content

This PR includes updates to end support for MacOS x64 builds in the CI and, consequently, the removal of pre-built binaries in releases. There's also a blog post to announce this change.

Important

This PR should be merged after the release of the upcoming distribution 2506.

Pre-submit checklist

  • Branch
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2250

@dlachaume dlachaume self-assigned this Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Test Results

    3 files   -   1     49 suites   - 7   10m 15s ⏱️ -22s
1 591 tests ±  0  1 591 ✅ ±  0  0 💤 ±0  0 ❌ ±0 
1 789 runs   - 100  1 789 ✅  - 100  0 💤 ±0  0 ❌ ±0 

Results for commit 1022bef. ± Comparison against base commit b797355.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 5, 2025 09:47 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the blog post

@dlachaume dlachaume force-pushed the dlachaume/2250/end-support-for-macos-x64-ci-builds branch from ff627eb to 1a59955 Compare February 5, 2025 10:42
@dlachaume dlachaume force-pushed the dlachaume/2250/end-support-for-macos-x64-ci-builds branch from 1a59955 to 1022bef Compare February 5, 2025 10:42
@dlachaume
Copy link
Collaborator Author

Looks good except for the blog post

Thanks! I've added more context in the blog post, does this look okay to you?

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 5, 2025 10:59 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud left review comments

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End of support for MacOS x64 builds in the CI
3 participants
@dlachaume @sfauvel @jpraynaud