Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for linux requirements upgrade #2275

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Add warning for linux requirements upgrade #2275

merged 5 commits into from
Feb 4, 2025

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 4, 2025 •
edited
Loading

Content

This PR add warnings for the upcoming glibc minimum version upgrade (from 2.31 to 2.35).

  • Docusaurus: Add a warning in the linux requirements block
  • Docusaurus: Add a blog post about the upcoming change
  • CI: Add a warning in the linux requirements block in our release note
  • install script: Add an automatic check of the glibc version when used on linux. If below the actual supported version of 2.31 the script will now fails with a message, if the version is supported but deprecated (between 2.31 and 2.34 included) a deprecation warning is shown.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2216

@Alenar Alenar self-assigned this Feb 4, 2025
@Alenar Alenar force-pushed the djo/2216/update-linux-requirements branch from b5d9e08 to 4fce9aa Compare February 4, 2025 15:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 29s ⏱️ -9s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8b6b925. ± Comparison against base commit 0163127.

♻️ This comment has been updated with latest results.

sfauvel
sfauvel approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpraynaud
jpraynaud approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/workflows/actions/prepare-distribution/action.yml Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
docs/website/blog/2025-02-04-glibc-minimum-requirement-change.md Outdated Show resolved Hide resolved
mithril-install.sh Outdated Show resolved Hide resolved
Alenar added 5 commits February 4, 2025 18:02
@Alenar
doc: add a warning about the upcoming min glibc version bump
5374656
@Alenar
doc(blog): add a blog post about the upcoming glibc min version bump
d9517c6
@Alenar
feat(install-script): add requirement check + fix usage
379176f 
Add a check that the required commands are installed (curl and jq).

Fix the usage output which wrongly suggested to use a `-n` option
instead of `-c` for the node choice.
@Alenar
feat(install-script): add glibc version check
3c3fde0 
Make the script fail if the installed version is below the supported
version (2.31).
Show a warning if the version is deprecated (between 2.31 and 2.34).
@Alenar
fix: adjusments following PR reviews
8b6b925
@Alenar Alenar force-pushed the djo/2216/update-linux-requirements branch from 4fce9aa to 8b6b925 Compare February 4, 2025 17:02
@Alenar Alenar temporarily deployed to testing-preview February 4, 2025 17:10 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 4, 2025 17:10 — with GitHub Actions Inactive
@Alenar Alenar merged commit b4ad474 into main Feb 4, 2025
43 checks passed
@Alenar Alenar deleted the djo/2216/update-linux-requirements branch February 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume