Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: compress aggregator HTTP responses #2226

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat: compress aggregator HTTP responses #2226

wants to merge 6 commits into from

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 15, 2025 •
edited
Loading

Content

This PR includes the activation of the compression of the HTTP responses of the aggregator in the infrastructure.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2225

@jpraynaud jpraynaud self-assigned this Jan 15, 2025
@jpraynaud jpraynaud marked this pull request as draft January 15, 2025 16:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 22s ⏱️ +15s
1 545 tests ±0  1 545 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 801 runs  ±0  1 801 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b815e3c. ± Comparison against base commit 693d95a.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 15, 2025 17:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2225-compress-aggregator-responses branch from 2265e0c to 65a0ba0 Compare January 16, 2025 09:40
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 16, 2025 09:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2225-compress-aggregator-responses branch from 84a551d to 3668192 Compare January 16, 2025 10:27
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 16, 2025 10:36 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 24, 2025 15:53 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2225-compress-aggregator-responses branch from 99ef039 to 979cfe3 Compare January 24, 2025 15:54
@jpraynaud jpraynaud marked this pull request as ready for review January 24, 2025 15:55
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 24, 2025 16:03 — with GitHub Actions Inactive
@jpraynaud
chore: upgrade traefik reverse proxy
f0169ec 
From '2.10' to '3.3'.
@jpraynaud
chore: activate aggregator response compression in infra
340e7cf 
Compression is done by the reverse proxy.
sfauvel
sfauvel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/2225-compress-aggregator-responses branch from 979cfe3 to 8849a09 Compare January 24, 2025 16:16
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 24, 2025 16:30 — with GitHub Actions Inactive
@jpraynaud
fix: memory leak in traefik with zstd/br compressions
ae9033d 
Use gzip compression only.
@jpraynaud
fix: add content encoding header in aggregator prover benchmark
dc304d2
@jpraynaud
chore: Update CHANGELOG
ce915e2
@jpraynaud
chore: bump versions
b815e3c 
- 'mithril-infra' from '0.3.11' to '0.3.12'
- 'benchmark/aggregator-prover' from '0.1.1' to '0.1.2'.
@jpraynaud jpraynaud force-pushed the jpraynaud/2225-compress-aggregator-responses branch from 8849a09 to b815e3c Compare January 24, 2025 16:56
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 24, 2025 17:04 — with GitHub Actions Inactive
@jpraynaud jpraynaud deployed to dev-preview January 24, 2025 17:29 — with GitHub Actions Active
@jpraynaud jpraynaud deployed to dev-mainnet January 24, 2025 17:29 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Awaiting requested review from Alenar

@dlachaume dlachaume Awaiting requested review from dlachaume

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activate compression of aggregator HTTP responses
2 participants
@jpraynaud @sfauvel