refacto: improve genesis creation tests

input-output-hk · Feb 3, 2025 · 7cf6061 · 7cf6061
1 parent 229f619
commit 7cf6061
Showing 1 changed file with 20 additions and 25 deletions.
diff --git a/mithril-common/src/crypto_helper/genesis.rs b/mithril-common/src/crypto_helper/genesis.rs
@@ -107,42 +107,37 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_generate_test_deterministic_genesis_keypair() {
-        let genesis_signer = ProtocolGenesisSigner::create_deterministic_genesis_signer();
-        let genesis_verifier = genesis_signer.create_genesis_verifier();
+    fn create_deterministic_genesis_keypair_always_return_the_same_value() {
+        let genesis_signer_1 = ProtocolGenesisSigner::create_deterministic_genesis_signer();
         let genesis_signer_2 = ProtocolGenesisSigner::create_deterministic_genesis_signer();
-        let genesis_verifier_2 = genesis_signer.create_genesis_verifier();
+
         assert_eq!(
-            genesis_signer.secret_key.to_bytes(),
+            genesis_signer_1.secret_key.to_bytes(),
             genesis_signer_2.secret_key.to_bytes()
         );
+
+        let genesis_verifier_1 = genesis_signer_1.create_genesis_verifier();
+        let genesis_verifier_2 = genesis_signer_2.create_genesis_verifier();
         assert_eq!(
-            genesis_verifier.verification_key.as_bytes(),
+            genesis_verifier_1.verification_key.as_bytes(),
             genesis_verifier_2.verification_key.as_bytes()
         );
-
-        println!(
-            "Deterministic Genesis Verification Key={}",
-            genesis_verifier.verification_key.to_json_hex().unwrap()
-        );
-        println!(
-            "Deterministic Genesis Secret Key=={}",
-            genesis_signer.secret_key.to_json_hex().unwrap()
-        );
     }
 
     #[test]
-    fn test_generate_test_non_deterministic_genesis_keypair() {
-        let genesis_signer = ProtocolGenesisSigner::create_non_deterministic_genesis_signer();
-        let genesis_verifier = genesis_signer.create_genesis_verifier();
-
-        println!(
-            "Non Deterministic Genesis Verification Key={}",
-            genesis_verifier.verification_key.to_json_hex().unwrap()
+    fn create_non_deterministic_genesis_keypair_return_different_values() {
+        let genesis_signer_1 = ProtocolGenesisSigner::create_non_deterministic_genesis_signer();
+        let genesis_signer_2 = ProtocolGenesisSigner::create_non_deterministic_genesis_signer();
+        assert_ne!(
+            genesis_signer_1.secret_key.as_bytes(),
+            genesis_signer_2.secret_key.as_bytes()
         );
-        println!(
-            "Non Deterministic Genesis Secret Key=={}",
-            genesis_signer.secret_key.to_json_hex().unwrap()
+
+        let genesis_verifier_1 = genesis_signer_1.create_genesis_verifier();
+        let genesis_verifier_2 = genesis_signer_2.create_genesis_verifier();
+        assert_ne!(
+            genesis_verifier_1.verification_key.as_bytes(),
+            genesis_verifier_2.verification_key.as_bytes(),
         );
     }