tryReadTBQueueDefault: fix bug when returning Nothing
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
amesgen/tryReadTBQueue
branch
from
173ac11 to
e349d6d
Compare
|
If you need it in |
amesgen
force-pushed
the
amesgen/tryReadTBQueue
branch
from
e349d6d to
f7c943c
Compare
I think it would be neat if it is not too much work, but it is not urgent for IOG stuff as one can work around this (I am also out of office until next year). |
|
Ah, just realized I have merge rights here... |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The CI failure seems unrelated to this PR |
amesgen
force-pushed
the
amesgen/tryReadTBQueue
branch
from
f7c943c to
7bc0ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195
AFAICT, there is no need to update the state of the
TBQueuewhen we didn't read anything.