Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cost model to be called without an actual witness #30

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Allow cost model to be called without an actual witness #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c913679
Update Cost model
iquerejeta Jan 24, 2025
befda0e
Update Cost model
iquerejeta Jan 24, 2025
b5053c0
Run apt-get update before installing libfontconfig
iquerejeta Jan 24, 2025
15fe1c6
Remove instance from cost model (use only nb_instances)
iquerejeta Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
override: false
- name: Install libfontconfig1-dev
if: runner.os == 'Linux'
run: sudo apt-get install -y libfontconfig1-dev
run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- name: Run tests
uses: actions-rs/cargo@v1
with:
Expand All @@ -45,7 +45,7 @@ jobs:
- wasm32-wasi

steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand All @@ -63,7 +63,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand All @@ -80,7 +80,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand All @@ -103,7 +103,7 @@ jobs:
timeout-minutes: 30
runs-on: ubuntu-latest
steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lints-beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
continue-on-error: true

steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lints-stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- run: sudo apt-get install -y libfontconfig1-dev
- run: sudo apt-get update && sudo apt-get install -y libfontconfig1-dev
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
with:
Expand Down
9 changes: 2 additions & 7 deletions examples/proof-size.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use halo2_proofs::{
};
use halo2curves::pasta::Fp;

use halo2_proofs::dev::cost_model::{from_circuit_to_model_circuit, CommitmentScheme};
use halo2_proofs::dev::cost_model::from_circuit_to_circuit_model;
use halo2_proofs::plonk::{Expression, Selector, TableColumn};
use halo2_proofs::poly::Rotation;

Expand Down Expand Up @@ -88,12 +88,7 @@ const K: u32 = 11;
fn main() {
let circuit = TestCircuit {};

let model = from_circuit_to_model_circuit::<_, _, 32, 32>(
Some(K),
&circuit,
vec![],
CommitmentScheme::KZGGWC,
);
let model = from_circuit_to_circuit_model::<_, _, 32, 32>(Some(K), &circuit, 10);
println!(
"Cost of circuit with 8 bit lookup table: \n{}",
serde_json::to_string_pretty(&model).unwrap()
Expand Down
Loading
Loading