Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working recursive test #27

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Conversation

iquerejeta
Copy link
Collaborator

This changes the exposure of certain function and types.

On top of that, it modifies the polynomial commitment scheme proof. We now use the multi-open argument as described in the halo2 book as that is more efficient for in-circuit verification.

The changes include a truncation of challenges in the proof generation/verification.

@iquerejeta iquerejeta force-pushed the iquerejeta/in-circuit-verification branch from a808223 to 04bb044 Compare January 16, 2025 09:10
src/transcript/mod.rs Show resolved Hide resolved
src/transcript/mod.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
src/plonk/keygen.rs Outdated Show resolved Hide resolved
src/plonk/keygen.rs Outdated Show resolved Hide resolved
src/poly/commitment.rs Outdated Show resolved Hide resolved
src/utils/arithmetic.rs Show resolved Hide resolved
src/poly/kzg/mod.rs Outdated Show resolved Hide resolved
src/transcript/mod.rs Show resolved Hide resolved
src/poly/kzg/utils.rs Outdated Show resolved Hide resolved
src/poly/kzg/utils.rs Outdated Show resolved Hide resolved
src/poly/kzg/mod.rs Show resolved Hide resolved
Copy link

@miguel-ambrona miguel-ambrona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

benches/plonk.rs Show resolved Hide resolved
src/plonk/circuit.rs Outdated Show resolved Hide resolved
src/plonk/keygen.rs Outdated Show resolved Hide resolved
src/plonk/permutation.rs Outdated Show resolved Hide resolved
src/poly/kzg/mod.rs Show resolved Hide resolved
src/poly/kzg/msm.rs Show resolved Hide resolved
src/poly/kzg/utils.rs Outdated Show resolved Hide resolved
src/utils/arithmetic.rs Outdated Show resolved Hide resolved
src/utils/arithmetic.rs Show resolved Hide resolved
@iquerejeta iquerejeta changed the base branch from iquerejeta/minor_changes to dev January 22, 2025 11:53
@iquerejeta iquerejeta force-pushed the iquerejeta/in-circuit-verification branch from 8aa4997 to e5256cf Compare January 22, 2025 11:54
@iquerejeta iquerejeta merged commit c5e0ba8 into dev Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants