Skip to content

Document the usage of the next-generation equivalence reasoner #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

jeltsch
Copy link
Contributor

@jeltsch jeltsch commented Nov 16, 2021

This resolves #4.

Copy link

@javierdiaz72 javierdiaz72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find below my conclusions of the review:

  • I didn’t find any typos or syntactic errors.
  • I didn’t find any errors related to antiquotations.
  • I have two recommendations aimed to aid the user, namely:
    • I think it would be great to add a minimal example including a custom equivalence relation R, a function f that is compatible with R, and a lemma involving a property of R that can be proved by the equivalence proof method.
    • I think it would be neat to use railroad diagrams to specify the syntax of the equivalence and try_equivalence proof methods.

@jeltsch
Copy link
Contributor Author

jeltsch commented Nov 30, 2021

Thank you very much for your thorough review.

I’d like to address your recommendations via separate issues:

If you’re otherwise happy with this pull request, could you please accept it? Thank you.

Copy link

@javierdiaz72 javierdiaz72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeltsch jeltsch merged commit d4cf163 into master Nov 30, 2021
@jeltsch jeltsch deleted the enhancement/next-generation-usage-documentation branch November 30, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the usage of the next-generation equivalence reasoner
2 participants